test(e2e): fix tests for new cucumber-js #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update cucumber tests to address the following incompatibilities: 1. usage of `defineSupportCode` instead of relying on invocation with appropriate `this` the modules `require`d by cucumber-js 2. replace regex literals with cucumber expression strings, as the former cause issues when non-existent capture groups are parsed 3. migrate from old-style tag selection syntax Fixes #2764
|
Rebased on master so all tests pass. |
dignifiedquire
approved these changes
Aug 15, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cucumber tests to address the following incompatibilities:
defineSupportCodeinstead of relying on invocation withappropriate
thisthe modulesrequired by cucumber-jsformer cause issues when non-existent capture groups are parsed
Fixes #2764